Strip trailing whitespace #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these, empty diffs would result in an error instead of empty diffs
Previous if you added something to the replace candidate, it would appear in the diff output with a - prefix instead of a plus
My text editor removes trailing whitespace automatically and it appears that the running config has trailing whitespace in it. This resulted in the diff being greater than the actual changes.
btobolaski
force-pushed
the
strip-trailing-whitespace
branch
from
6441906
to
7184784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #4
When testing out
compare_config(), I noticed that the diff was much larger than I would have expected it to be. This is the result of my text editor automatically removing trailing whitespace and the running config having considerable trailing whitespace in it.I would understand if this isn't a change you would like in the library.